php-groups.com | Post Question | Search | About | Groups | Contact | Register | Login


New in This Group

PECL packagesand SVN
11/11/2009 11:04:30 AM

Daily/weekly commit logs
11/3/2009 12:21:39 PM

svn:external for pear/packages/*/trunk and pecl/*/trunk
7/22/2009 10:18:55 AM

moving svn.pear.php.net over to svn.php.net
7/21/2009 4:14:40 PM

SVN compression.
7/21/2009 11:27:48 AM

typo in my username
7/19/2009 10:06:06 AM

viewvc and blame on props?
7/19/2009 12:38:06 AM

To late to rename /repository/web modules?
7/18/2009 11:53:51 PM

Fwd: [DOC-WEB] svn: web/doc/trunk/ build-ops.in build-ops.php.in configure configure.in include/docweb_language.class.php include/lib_general.inc.php include/lib_phpt_generator.inc.php include/lib_r
7/17/2009 8:03:23 AM

once again, commit email subject lines?
7/14/2009 10:15:31 PM

svn: SVNROOT/ commit-email.php Reply

Group: svn.migration Subscribe Posted:7/18/2009 10:18:28 PM Replies:0 Views:7 Items(0)
--e2b0bedc7b5711c78bf178d3b35b4d772c2dd581
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

rasmus Sat, 18 Jul 2009 22:18:28 +0000

URL: http://svn.php.net/viewvc?view=revision&revision=284338

Changed paths:
U SVNROOT/commit-email.php

Log:
Try to be smarter about which bug url to use - Hopefully we will
be down
to a single unified bug system soon


Modified: SVNROOT/commit-email.php
===================================================================
--- SVNROOT/commit-email.php 2009-07-18 21:46:52 UTC (rev 284337)
+++ SVNROOT/commit-email.php 2009-07-18 22:18:28 UTC (rev 284338)
@@ -184,6 +184,11 @@
$boundary = sha1("{$commit_user}{$commit_date}");
$messageid = "{$commit_user}-{$commit_date}-{$REV}-" . mt_rand();
$subject = "svn: " . ($parent_path === '' ? '/' : $parent_path);
+switch (substr(trim($changed_paths[0]),4)) {
+ case 'pear': $bug_url = 'http://pear.php.net/bugs'; break;
+ case 'pecl': $bug_url = 'http://pecl.php.net/bugs'; break;
+ default: $bug_url = 'http://bugs.php.net'; break;
+}
foreach ($changed_paths as $changed_path) {
$changed_path = trim(strstr($changed_path, ' '));
if (substr($changed_path, -1) !== '/') {
@@ -205,7 +210,7 @@
$bugs_body = '';
if ($bugs) {
foreach ($bugs_array[1] as $bug_id) {
- $bugs_body .= " http://bugs.php.net/$bug_id\r\n";
+ $bugs_body .= " $bug_url/$bug_id\r\n";
}
}


--e2b0bedc7b5711c78bf178d3b35b4d772c2dd581--
ras...@php.net (=?utf-8?q?Rasmus_Lerdorf?=)
7/18/2009 10:18:28 PM




On Sun, Jul 19, 2009 at 00:18, Rasmus Lerdorf<rasmus@php.net> wrote:
> rasmus =A0 =A0 =A0 =A0 =A0Sat, 18 Jul 2009 22:18:28 +0000
>
> URL: http://svn.php.net/viewvc?view=3Drevision&revision=3D284338
>
> Changed paths:
> =A0 =A0 =A0 =A0U =A0 SVNROOT/commit-email.php
>
> Log:
> Try to be smarter about which bug url to use - Hopefully we will
> be down
> to a single unified bug system soon

Can we/I create a magical "backdoor" into the current bugs.php.net
bugtracker that will automatically add a link to viewvc of the commit
to the associated bug report as a comment? (the developer still needs
to mark the report as closed, automating that part can lead to
confusion and wrongly closing "partially fix bug#nnnn" commits).

It would be very helpful for all linux distros, the documentation
team, and probably others.

-Hannes
hannes.magnus...@gmail.com (Hannes Magnusson)
7/18/2009 11:40:23 PM

Hannes Magnusson wrote:
> On Sun, Jul 19, 2009 at 00:18, Rasmus Lerdorf<rasmus@php.net> wrote:
>> rasmus Sat, 18 Jul 2009 22:18:28 +0000
>>
>> URL: http://svn.php.net/viewvc?view=revision&revision=284338
>>
>> Changed paths:
>> U SVNROOT/commit-email.php
>>
>> Log:
>> Try to be smarter about which bug url to use - Hopefully we will
>> be down
>> to a single unified bug system soon
>
> Can we/I create a magical "backdoor" into the current bugs.php.net
> bugtracker that will automatically add a link to viewvc of the commit
> to the associated bug report as a comment? (the developer still needs
> to mark the report as closed, automating that part can lead to
> confusion and wrongly closing "partially fix bug#nnnn" commits).
>
> It would be very helpful for all linux distros, the documentation
> team, and probably others.

Right, it is trivial for the php bug tracker because it is on the same
machine, but a bit harder for the pecl/pear bugs. We need an actual API
there for those. I'll add something to the existing bug tracker tonight
most likely and we can put it on the list of things to look at for the
new unified bug tracker.

-Rasmus
ras...@lerdorf.com (Rasmus Lerdorf)
7/19/2009 12:42:26 AM


Reply:
| or Email(not shown): Name: | Register | Login

Alert me when someone responds to this posting.








Newest Articles

note 97095 added to soapclient.soapclient
4/1/2010 5:58:19 AM

note 97094 added to function.sqlite-changes
4/1/2010 5:06:46 AM

note 97093 added to function.sqlite-changes
4/1/2010 5:06:21 AM

note 97092 added to ref.xmlrpc
4/1/2010 4:52:18 AM

note 97091 added to function.var-export
4/1/2010 3:32:03 AM